Configure "delete account" button behavior#1339
Open
megastep wants to merge 3 commits intofirebase:mainfrom
Open
Configure "delete account" button behavior#1339megastep wants to merge 3 commits intofirebase:mainfrom
megastep wants to merge 3 commits intofirebase:mainfrom
Conversation
….swift Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
![gemini-code-assist[bot]](https://avatars.gh.lumenfield.work/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the ability to customize the account deletion button behavior in SignedInView via the AuthConfiguration. It adds a new DeleteAccountButtonAction enum allowing the button to be shown with a default confirmation sheet, hidden entirely, or linked to a custom action. Additionally, it includes UI updates to conditionally display the MFA management and delete account buttons, localizes strings in the deletion confirmation sheet, and adds corresponding unit tests and documentation. I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the "Delete Account" button in the SignedInView configurable, for cases when the application needs more advanced account deletion configuration:
This also includes the changes from my previous PR #1338 to disable the MFA button if that is turned off in the project's configuration.
Also fixes some missing localized strings in the dialog, even though the strings were already localized.